Re: [PATCH] klogd core

On Fri, Jul 04, 2008 at 04:16:31PM +0200, Martin Schulze wrote:
> Sean Young wrote:
> > With /proc/kallsyms disabled in the kernel, klogd crashes. fclose(NULL) is
> > executed.
>
> Hmbf! Do you know since which version?

Looking at the history, I assume klogd 1.5.

http://cvs.infodrom.org/sysklogd/ksym_mod.c

However I have not tested earlier versions.

> > --- ksym_mod.c.orig 2008-07-04 14:43:39.000000000 +0100
> > +++ ksym_mod.c 2008-07-04 14:43:48.000000000 +0100
> > @@ -189,7 +189,6 @@
> > else
> > Syslog(LOG_ERR, "Error loading kernel symbols " \
> > "- %s\n", strerror(errno));
> > - fclose(ksyms);
> > return(0);
> > }
>
> It would be better to test if ksyms is NULL (or not resp.).

It doesn't show in this diff, but in this code path ksysm is always NULL.

Sean
Received on Fri Jul 04 2008 - 16:26:04 CEST