Re: [PATCH] klogd core

Sean Young wrote:
> With /proc/kallsyms disabled in the kernel, klogd crashes. fclose(NULL) is
> executed.

Hmbf! Do you know since which version?

> --- ksym_mod.c.orig 2008-07-04 14:43:39.000000000 +0100
> +++ ksym_mod.c 2008-07-04 14:43:48.000000000 +0100
> @@ -189,7 +189,6 @@
> else
> Syslog(LOG_ERR, "Error loading kernel symbols " \
> "- %s\n", strerror(errno));
> - fclose(ksyms);
> return(0);
> }

It would be better to test if ksyms is NULL (or not resp.).

Regards,

        Joey

-- 
Linux - the choice of a GNU generation.