Re: [PATCH] klogd core

Andrea Morandi wrote:
> Hi all,
>
> This is the same bug I pointed out on April 2008 (see mailing-list
> archive for reference).

Ouch! Sorry, must have missed it.

> Here is the problem:
>
> IF (KSYMS == NULL) => FCLOSE(KSYMS)
>
> And here is the code:
>
> if ( ksyms == NULL )
> {
> if ( errno == ENOENT )
> Syslog(LOG_INFO, "No module symbols loaded - "
> "kernel modules not enabled.\n");
> else
> Syslog(LOG_ERR, "Error loading kernel symbols " \
> "- %s\n", strerror(errno));
> fclose(ksyms);
> return(0);
> }
>
>
> It's useless to test if ksyms is NULL as the code is executed ONLY if it
> IS NULL.
> The patch provided by Mr. Young is correct, it 's enough to remove
> fclose line.

Ack!

Committed.

Thanks to both of you,

        Joey

-- 
Linux - the choice of a GNU generation.