Re: [eichin@kitten.gen.ma.us: Bug#22816: cfingerd mishandles .nofinger]


Martin Schulze (joey@kuolema.Infodrom.North.DE)
Sun, 31 May 1998 22:05:53 +0200


On Mon, May 25, 1998 at 10:47:41AM +0200, Martin Schulze wrote:

> ----- Forwarded message from Mark Eichin <eichin@kitten.gen.ma.us> -----
>
> package: cfingerd
> Version: 1.3.2-9
>
> cfingerd is supposed to *display* the contents of ~user/.nofinger, not
> just print nothing at all. With the stock cfingerd.conf, this doesn't
> happen, as I think the following demonstrates sufficiently. This used
> to work but I don't know how long ago. (I have some users that really
> do wish to remain hidden [on another system], I'd *rather* have some
> way to indicate "just display the contents of
> /etc/cfingerd/nouser_banner.txt for this user" but that's a seperate
> issue... it should instead at least work as documented....)

This has been fixed, too. The wrong code was in standard.c

    if (S_ISREG(statbuf.st_mode))
        return(FALSE);
    else
        syslog(LOG_NOTICE, "%s's file %s is NOT A REGULAR FILE.",
               user, str);

As you can see the symantics of this i-t-e is wrong. The following
construct is correct.

    if (!S_ISREG(statbuf.st_mode)) {
        syslog(LOG_NOTICE, "%s's file %s is NOT A REGULAR FILE.",
                user, str);
        return(FALSE);
    }

This will be in the -10 Debian release.

Regards,

        Joey

-- 
  / Martin Schulze  *  joey@infodrom.north.de  *  26129 Oldenburg /
 /                                     http://home.pages.de/~joey/
/ Unix is user friendly ...  It's just picky about it's friends /




This archive was generated by hypermail 2.0b3 on Sun Aug 08 1999 - 10:46:55 CEST